svandragt / psh

PHP Virtual Environment Shell
MIT License
0 stars 0 forks source link

Parameter Expansion #4

Closed tomjn closed 3 years ago

tomjn commented 3 years ago

There are places where bash variables are used without quotes, which will cause issues with folders that have spaces, as well as parameters that contain them, causing expansion and possible execution attacks

svandragt commented 3 years ago

Thanks for the report tom! I guess you have this situation? This should be fixed by rewriting c73b7c03d78593df5df530650c2eac4981a3e0e5 using shellcheck. If there are any instances I've missed feel free to reopen this.