search

svartalf / rust-battery

Rust crate providing cross-platform information about the notebook batteries.
https://crates.io/crates/battery
Apache License 2.0
354 stars 40 forks source link

Update version of mach. #52

Open jdm opened 4 years ago

jdm commented 4 years ago

As far as I can tell its types are not exposed through the public API, so this shouldn't require a major version change.

svartalf commented 4 years ago

Hm, can you rebase from master branch? I forgot to add the CI execution on the PRs for this repo, at least we can do the tests.

Yet, I think I'll not be able to merge it right now, as there is probably the same issue as with https://github.com/svartalf/rust-battery/pull/38#issuecomment-549019461; it will bump MSRV and it is probably undesired right now. Do you have any specific needs to bump the mach version?

jdm commented 4 years ago

Only to avoid duplicate dependencies in Servo.

svartalf commented 4 years ago

@jdm wait, you mean Servo is using/going to use battery? Seems to be a noble reason to publish the new version then :D

jdm commented 4 years ago

It's used indirectly through wgpu-core, and we're apparently pulling battery in as part of https://github.com/servo/servo/pull/25507. Duplicating mach isn't a big deal; make the choices that make sense for your primary consumers :)

svartalf commented 4 years ago

Ah, yes, barely found it: https://github.com/gfx-rs/wgpu/blob/9777bbba361690740c62fd294b968ac6f2340506/wgpu-core/Cargo.toml#L50-L51 For some reasons it is not shown at the "Reverse dependencies" page for the battery crate.

Bumping mach version is a long due task, in fact, I think we can manage it happen; probably by including some additional issues into the next release. Let's postpone this PR and I'll check what I can do with it.