search

svb-hikip / hikipfe-react-public

4 stars 20 forks source link

Task 5 - Invoice page #31

Closed svb-hikip closed 2 months ago

svb-hikip commented 2 months ago

image

Fix the invoice page to replace dummy data with original data

AmaamRizvi commented 2 months ago

please provide details for this

Mdsugail commented 2 months ago

for the task 5 Invoice page ?

On Tue, Jun 11, 2024 at 2:07 PM Amaam_Rizvi @.***> wrote:

please provide details for this

— Reply to this email directly, view it on GitHub https://github.com/svb-hikip/hikipfe-react/issues/31#issuecomment-2160127586, or unsubscribe https://github.com/notifications/unsubscribe-auth/A67WWU42C7XNQZ4RZ4C6G5DZG2ZN7AVCNFSM6AAAAABJCYXUKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQGEZDONJYGY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

AmaamRizvi commented 2 months ago

for the task 5 Invoice page ? … On Tue, Jun 11, 2024 at 2:07 PM Amaam_Rizvi @.> wrote: please provide details for this — Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A67WWU42C7XNQZ4RZ4C6G5DZG2ZN7AVCNFSM6AAAAABJCYXUKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQGEZDONJYGY . You are receiving this because you are subscribed to this thread.Message ID: @.>

for the task 5 Invoice page ? … On Tue, Jun 11, 2024 at 2:07 PM Amaam_Rizvi @.> wrote: please provide details for this — Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A67WWU42C7XNQZ4RZ4C6G5DZG2ZN7AVCNFSM6AAAAABJCYXUKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQGEZDONJYGY . You are receiving this because you are subscribed to this thread.Message ID: @.>

Yes

svb-hikip commented 2 months ago

I got the API ready. Pull the new changes before you proceed.

API ENDPOINTS AND DOCS https://hikip-django-e06ccc5f06d1.herokuapp.com/api/schema/swagger-ui/

https://hikip-django-e06ccc5f06d1.herokuapp.com/api/schema/redoc/

svb-hikip commented 2 months ago

@aditya28n99 Can you please takeup this task?

aditya28n99 commented 2 months ago

Sure, I'll work on it. Thanks for the assignment.

aditya28n99 commented 2 months ago

@svb-hikip I have reviewed the provided documentation, However, I'm still unclear on the exact endpoints and response structures needed to fetch the necessary data. Could you please provide the specific API endpoints and the expected response bodies for fetching: Invoice details Activity details

svb-hikip commented 2 months ago

@aditya28n99 Please try now, the data on this page is all you need to fill the invoice details. I have modified the backed. image

aditya28n99 commented 2 months ago

@svb-hikip I think some problem was occured due to asynchronous issues, but it get resolved. now successfully destructured the nested data and accessed most of the fields correctly. will update u soon. thanks!!

aditya28n99 commented 2 months ago

I have replaced the invoice data by actual data, please review the ss. image

I'll recorrect the UI once it completed. If you have any suggestions please guide me. Thanks.

svb-hikip commented 2 months ago

Looks Good Maybe modify Hours to Quantity? add comma separators to the values? You have removed the payments and notes component, Please put them back. We will develop them too.

aditya28n99 commented 2 months ago

Yes, I've restored the payments and notes components. However, I'm encountering difficulty fetching data for the 'From' and 'To' sections. Currently, I've only integrated the 'first_name' and 'last_name' properties there. and other feilds are hadcoded.. Could you please provide guidance on this? image

svb-hikip commented 2 months ago

Completed by @aditya28n99