search

svdgraaf / serverless-fargate-tasks

Run Fargate tasks within your serverless project
43 stars 21 forks source link

Ability to use stack outputs / CloudFormation functions in environment? #6

Closed wizardishungry closed 5 years ago

wizardishungry commented 5 years ago

I'm curious if removing this block would allow me to use stack outputs in my task defintions?

 // any non-string value needs to be send through as json
svdgraaf commented 5 years ago

Hmmm, good catch. I think it would, you can use it for ref's then as well. I'm not sure anymore why I added this specific if statement tbh.

I'll make this into a point release because it's potentially a breaking change.

svdgraaf commented 5 years ago

I just released a point release 0.4.0 with these changes.

wizardishungry commented 5 years ago

Are you sure you published it correctly –

$ curl 2> /dev/null https://registry.npmjs.org/serverless-fargate-tasks/-/serverless-fargate-tasks-0.4.0.tgz | gunzip - | grep -a JSON.stringify
            environment.push({"Name": key, "Value": JSON.stringify(value)})
svdgraaf commented 5 years ago

Interesting! Let me check :)

svdgraaf commented 5 years ago

Ok, I made a booboo. I just released 0.4.1 which should be okay now 😅 Sorry for that!

wizardishungry commented 5 years ago

No worries! 🥂