sveale / remote-edit

remote-edit
MIT License
146 stars 55 forks source link

Incorrect download files with different charsets #110

Closed stdex closed 9 years ago

stdex commented 9 years ago

1) I have file with windows-1251 charset. When I open it in notepad++ it's opened in correct charset. 2) When I try to open this file with your plugin it convert text (contains of file) to utf8 and convert charset of file to utf8. It broke text in file and I can't restore it back. (I can change charset, but it's not working, becouse your plugin convert text to utf8 too) 3) If I'm open local file with windows-1251 charset in atom.io I can change charset and text are not broken in it. Also I use plugin auto-encoding that can do it automatical.

You can see screenshot, it really problem in remote-edit, e.g. remote-ftp package work with my files correctly.

image image image

sveale commented 9 years ago

This should be fixed in the patch I just pushed, remote-edit@v1.8.15. Can you check and confirm?

stdex commented 9 years ago

It looks like fixed.