sveale / remote-edit

remote-edit
MIT License
146 stars 55 forks source link

quickfix for TextEditor constructor going private #144

Closed mike-kfed closed 8 years ago

mike-kfed commented 8 years ago

issue of serializing and deserializing is not solved! Mostly because I have no insight how and where that helps. Opening and saving in Atom 1.2.0 works now with this fix (should also work in lower versions) - maybe take it as a starting point for creating a full workaround for the fact TextEditor class constructor should no longer be called directly. Serializing, or actually deserializing, without a derived class - no clue how that should work, this is why I didn't implement any of the two. Maybe chime in with issue https://github.com/atom/atom/issues/9237 to get a hack-less implementation going ;)

mike-kfed commented 8 years ago

that workaround turned out to be hopeless when it came to de-/serializing