search

sveale / remote-edit

remote-edit
MIT License
146 stars 55 forks source link

cleaner implementation of RemoteEditEditor #146

Closed mike-kfed closed 8 years ago

mike-kfed commented 8 years ago

serializer possibly works too, broken in Atom see https://github.com/atom/atom/pull/9664

sorry for my first pull request with the crazy workaround for atom 1.2.x this one is cleaner and should work fine

mike-kfed commented 8 years ago

for me apm test works, that's on OS X, I have no clue what Appveyor does or how it works, since its logs say it runs against atom-1.0.7 it's output is useless anyways since my fix is for atom 1.2.3 or higher. I hope my workarounds help you, for me remote editing works fine now thanks for your initial work!

sveale commented 8 years ago

Thanks for the MR! :+1: