search

sveale / remote-edit

remote-edit
MIT License
146 stars 55 forks source link

Remove reference to removed display-buffer #187

Closed dfreese closed 7 years ago

dfreese commented 8 years ago

Atom 1.9.0 removed display-buffer. Use the deserializer in TextEditor instead.

dfreese commented 8 years ago

I'm new to coffee script here, but this helped me out after an update to Atom v1.9.0.

8bitben commented 8 years ago

dfreese's update worked for me too - thanks!

loustler commented 8 years ago

@dfreese Thanks

drq883 commented 8 years ago

+1 to @dfreese

Thanks. Back in business.

SageHarvey commented 8 years ago

I'm no longer seeing autocomplete / tab completion. Anyone else having this problem? Works fine with local and network mapped shared files, but trying to edit a file opened via remote-edit doesn't display the completion options. They still work (i.e. ifmain in python), just not visible.

dfreese commented 8 years ago

@SageHarvey, are you referring to the drop-down menu like this one? If so, that still works for me.

screen shot 2016-08-09 at 1 49 48 pm

SageHarvey commented 8 years ago

@dfreese, no, I meant this: image

If I try that with a file opened with remote-edit I don't see any options. I can still press tab if I know there's a snippet there and it will fill in.

kylelamse commented 8 years ago

Why hasn't this been merged yet?

dfreese commented 8 years ago

@SageHarvey, yeah, I'm seeing that same issue.

I'm also seeing an issue where the editor window hangs and doesn't show the previously open files if I close atom with a remote file open. Anyone else seeing this issue with this PR?

Clearly a couple things to take a look at.

goatboy91587 commented 8 years ago

Thank you so much! Worked like a charm :+1:

walles commented 7 years ago

I vote for merging this and dealing with any fallout in separate tickets.

This patch may or may not have problems, but without it nothing works any more.

walles commented 7 years ago

@sveale could you add two or three people as collaborators and let them merge this and release a new version?

That would enable this (very popular) project to live on without you having to do much of anything.

Having left a number of projects behind myself I can totally see how this project might not be your top priority any more :).

This comment is based on the fact that the last change to this project is about 10 months old when I type this.

sveale commented 7 years ago

Hi,

Sorry for the inconvenience. I'll look into this over the weekend and add collaborators as you suggest :)

Regards, Sverre Aleksandersen

Den 25. nov. 2016 kl. 11.22 skrev Johan Walles notifications@github.com:

@sveale could you add two or three people as collaborators and let them merge this and release a new version?

That would enable this (very popular) project to live on without you having to do much of anything.

Having left a number of projects behind myself I can totally see how this project might not be your top priority any more :).

This comment is based on the fact that the last change to this project is about 10 months old when I type this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mateddy commented 7 years ago

@sveale How about consider to merge with the fork https://github.com/duxet/remote-edit2 ?