search

sveawebpay / php-integration

SDK for Sveas payment methods (standalone and Svea Checkout)
Other
15 stars 19 forks source link

Wrong and conflicting classname in file #81

Closed sirn-se closed 6 years ago

sirn-se commented 6 years ago

The file src/AdminService/AdminSoap/CreditInvoiceRequest.php defines the class CreditInvoiceRowsRequest, which should (obviously) be CreditInvoiceRequest instead.

The class CreditInvoiceRowsRequest is already (correctly) defined in filesrc/AdminService/AdminSoap/CreditInvoiceRowsRequest.php, also causing to a conflict in class loading.

sirn-se commented 6 years ago

Or possibly, the file src/AdminService/AdminSoap/CreditInvoiceRequest.php should simply be removed. I can´t see the class CreditInvoiceRequest being used.

fre-sund commented 6 years ago

I'll take a look at it this afternoon. Thanks for reporting the issue!

fre-sund commented 6 years ago

You're right, it's not being used and it seems like its just a copy of CreditInvoiceRowsRequest except for the filename. I've removed the file and published a new release.

Closing this issue, thanks again!