search

svecosystem / runed

Magical utilities for your Svelte applications (WIP)
https://runed.dev
MIT License
461 stars 23 forks source link

Improve Media Query Utility #64

Closed abdel-17 closed 3 months ago

abdel-17 commented 3 months ago

Some minor improvements on #63

1- Use internal utilities and types like useEventListener to simplify the code. 2- Make the match property private to prevent external mutation. 3- Update useEventListener's types to accept a MediaQueryList.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: f18a7c589290b3bd19388ca7780a1c867ea41499

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 months ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
runed ✅ Ready (View Log) Visit Preview f18a7c589290b3bd19388ca7780a1c867ea41499
paoloricciuti commented 3 months ago

Some minor improvements on #63

1- Use internal utilities and types like useEventListener to simplify the code. 2- Make the match property private to prevent external mutation. 3- Update useEventListener's types to accept a MediaQueryList.

Very good improvements indeed 🤟🏻🤟🏻🤟🏻