chore: use esm-env For Browser Checks

svecosystem / runed

Magical utilities for your Svelte applications (WIP)

https://runed.dev

MIT License

387 stars 21 forks source link

chore: use esm-env For Browser Checks #79

Closed abdel-17 closed 1 month ago

abdel-17 commented 1 month ago

This pr removes the isBrowser() function in favor of using esm-env. It's tree-shakable and just exports a constant instead of relying on runtime code.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 4372bd36ac40d8e16e4b7cdcd105005612fe0294

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----- | ----- | | runed | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
runed	✅ Ready (View Log)	Visit Preview	4372bd36ac40d8e16e4b7cdcd105005612fe0294

huntabyte commented 1 month ago

Seems like vitest or the environment doesn't like esm-env. The tests pass when I pull locally and swap it for the previous.