search

sveetch / boussole

Command line interface to build Sass projects using 'libsass-python'.
http://boussole.readthedocs.io
MIT License
10 stars 5 forks source link

tried python 3 again #14

Closed feth closed 8 years ago

feth commented 8 years ago

I had 5 mn in the train...

sveetch commented 8 years ago

that's nice, did you had time also to check your changes with tests ?

feth commented 8 years ago

not yet ;-)

sveetch commented 8 years ago

Well, i installed a Python 3.4 env for Boussole and tested your both PR and i have a lot of fails because of my incompatible usage of basestring and bytes. The first one is easy, for the second one it will take more time to resolve.

feth commented 8 years ago

@sveetch can you point out the failure (trace) ?

sveetch commented 8 years ago

I finally fixed the first issue on basestring usage since commit 178cb78 on branch python3_support.

The second one is almost only about items order in asserted lists from various tests. You should install this branch and launch the tests to see them.