search

sveetch / crispy-forms-foundation

Django application to add 'django-crispy-forms' layout objects for Foundation
https://crispy-forms-foundation.readthedocs.io
MIT License
82 stars 44 forks source link

Missing row.html and column.html templates in 0.8.0 #46

Open mpasternak opened 4 years ago

mpasternak commented 4 years ago

Hi,

this commit:

https://github.com/sveetch/crispy-forms-foundation/pull/43/commits/78759aa8e71daa90e8f2618e606761464fb7e7e8#diff-1a77a0ef39514b22b57499cd39df30c1

had both row.html and column.html and it looks like they're missing in release 0.8.0. Could you please add those files and release it to PyPI? Thanks!

sveetch commented 4 years ago

Yep, this is because grid column and row are already implemented through grid layout components:

https://crispy-forms-foundation.readthedocs.io/en/latest/layout/grid.html

mpasternak commented 4 years ago

Silly me! Instead of importing crispy_forms_foundation.layout, I was importing from crispy_forms.layout. This gave me error about missing foundation6/layout/col.html and such.

Perhaps this bug I encountered could be documented somewhere, how do you think?

sveetch commented 4 years ago

I could write a warning line about this in documentation, it won't cost anything, still i don't know i will have the heart to release documentation just for this :)

I will keep this issue open to remember it for a possible next release.