search

sveinse / zaptec

zaptec charger custom component for home assistant
MIT License
10 stars 2 forks source link

feat: enable set limit service #25

Closed Gyran closed 1 year ago

Gyran commented 1 year ago

Not done yet, but wanted to get your input. I have implemented so that setting limit works just as before. If you think something like this is ok I'll do some cleanup and checks.

Should we remove all other service class as there are actions on the charger entities now or should I make them work as well?

I think it would make sense to only keep the set_limit service as it's the only one that isn't easily done with updating a state. What do you say?

sveinse commented 1 year ago

Thank you for this initative! However, I have recently pushed a fix for this in version 485969a90c06edbf9edfa93bca31baab889ce00f.

I've refactored the services, making them more interactive in HA UI. Now it is possible to select which charger (unfortunately there is no way to filter out installation and charger objects).

I haven't considered which service calls to keep and what to remove, now that most (except limit_current) are available as buttons. However, i chose to keep them for now for legacy purposes.

PS! I'm developing in the dev branch and not in deploy, so any PRs must be against dev, not deploy. There are some differences between the two branches.

Gyran commented 1 year ago

Nice, then I'll close this and see if I can help out with something else 😅