search

svelte-on-solana / wallet-adapter

Svelte wallet adapter for Solana Dapps
https://solana-svelte-counter.netlify.app/
Apache License 2.0
61 stars 24 forks source link

Customize maxNumberOfWallets with WalletMultiButton #26

Closed andrewjmeier closed 2 years ago

andrewjmeier commented 2 years ago

Is your feature request related to a problem? Please describe. WalletModal has a maxNumberOfWallets prop, but if you use WalletMultiButton to render it, WalletMultiButton does not expose the prop.

Describe the solution you'd like Add the same prop to WalletMultiButton and pass it through to the modal

Describe alternatives you've considered I could render the modal directly but that would more or less require rewriting WalletMultiButton myself.

Additional context I created this change in a branch here: https://github.com/svelte-on-solana/wallet-adapter/compare/master...andrewjmeier:andrew/customize-modal-wallet-count?expand=1 I'd be happy to submit a PR.

silvestrevivo commented 2 years ago

Hi @andrewjmeier please, feel free to open a PR to see the changes. Thanks!!

andrewjmeier commented 2 years ago

@silvestrevivo done: https://github.com/svelte-on-solana/wallet-adapter/pull/27

andrewjmeier commented 2 years ago

@silvestrevivo can we merge?

silvestrevivo commented 2 years ago

@andrewjmeier I left a comment on the PR. Thanks!

silvestrevivo commented 2 years ago

Changes published https://www.npmjs.com/package/@svelte-on-solana/wallet-adapter-ui/v/1.0.14-alpha.0