--datepicker-container-border won't work

svelte-plugins / datepicker

A simple datepicker component designed for Svelte.

https://svelte-plugins.github.io/datepicker

MIT License

54 stars 12 forks source link

--datepicker-container-border won't work #15

Closed Set27 closed 7 months ago

Set27 commented 7 months ago

    :global(.datepicker[data-picker-theme='custom-datepicker']) {
        --datepicker-container-position: relative;
        /* --datepicker-container-width: max-width; */
        --datepicker-calendar-width: 375px;

        --datepicker-state-active: white;
        --datepicker-calendar-header-text-color: #black;
        --datepicker-calendar-day-color: #white;
        --datepicker-calendar-range-selected-background: #111;

        --datepicker-border-color: #111;

        --datepicker-container-border: 100px solid #111;
    }

dysfunc commented 7 months ago

Can you pull down the changes and let me know if this fixes everything for you https://github.com/svelte-plugins/datepicker/pull/16

Set27 commented 7 months ago

@dysfunc can I somehow pull it for my existing project? Or you expected that I would clone this repo and test it? (sorry for stupid question) I did yarn add svelte-plugins/datepicker#pull/16/head but now Cannot find module '@svelte-plugins/datepicker' or its corresponding type declarations

dysfunc commented 7 months ago

It's not a stupid question. You need to either build dist by running pnpm build inside the node_modules/@svelte-plugins/datepicker folder, or the fastest way is to install the latest published version and replace the contents of the changed files inside the node_modules/@svelte-plugins/datepicker/dist folder. Then, just rebuild your app, and it should take the changes.

Set27 commented 7 months ago

@dysfunc see interesting behavior

https://github.com/svelte-plugins/datepicker/assets/49077110/c38a2063-4523-45b6-b516-017dd9a047f0

dysfunc commented 7 months ago

can you share REPL or stackblitz url with your configuration?

Set27 commented 7 months ago

@dysfunc https://svelte.dev/repl/ef2a644ef9244c3197d1183973c494b5?version=4.2.12

dysfunc commented 7 months ago

I don't see any rendering issues. What should I be looking for?

Set27 commented 7 months ago

@dysfunc it's not render border at all

dysfunc commented 7 months ago

Please update to the latest release and let me know if this is resolved.

dysfunc commented 7 months ago

Please update to the latest release and let me know if this is resolved

Set27 commented 7 months ago

@dysfunc it's resolved :heart: