search

sveltejs / cli

The Svelte CLI
MIT License
261 stars 11 forks source link

chore: avoid template creation message partway through setup #162

Closed benmccann closed 1 month ago

benmccann commented 1 month ago

It was a bit odd that it said "Project created" when you're only partway done. I tried changing the message to something else, but this resulted in the cleanest experience

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 138847fec655b4564f2408cf3422a49a16f0ebca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---- | ----- | | sv | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@162

commit: 138847f

benmccann commented 1 month ago

It's a little funny to me because everything else is a question until you're done. It's the only progress indicator that's printed. And I don't know that it's particularly important for the user to know that the template is copied partway through the setup. The only reason they would need to know that is if they cancel partway through so that they're aware the directory was created eventhough they cancelled. Otherwise it's just extraneous information, so it's cleaner to omit it

Screenshot from 2024-10-16 12-28-17

AdrianGonz97 commented 1 month ago

i still view this as a complete non-issue that if we attempt to remedy will actively make our code worse. in an ideal world, everything would be collected before processing, but given that these are two completely different actions, one following the other is fine.

also, outright removing the log isn't good either as status logs are important in conveying what's being/has been done.

benmccann commented 1 month ago

Yeah, if we could collect all the options before processing that would be nice. I didn't think I'd have time to do that before launch, but we could go back to clean it up later to work like that

manuel3108 commented 1 month ago

i still view this as a complete non-issue that if we attempt to remedy will actively make our code worse. in an ideal world, everything would be collected before processing, but given that these are two completely different actions, one following the other is fine.

also, outright removing the log isn't good either as status logs are important in conveying what's being/has been done.

Agree, this isn't an issue for me either, but removing the log isn't an option for me either.