search

sveltejs / cli

The Svelte CLI
MIT License
259 stars 11 forks source link

Rename lucia adder to auth #247

Closed benmccann closed 4 hours ago

benmccann commented 3 weeks ago

Folks are getting really confused and thinking it's using a deprecated library

Rich-Harris commented 3 weeks ago

It does feel a bit 'one true auth solution' if we do that, and I'm not sure that it is — I can't log in with google or github or biometrics or a passkey or whatever, there's no bot detection or email verification or password resets or the many other things that go into authentication, and we don't have anything to say about authorization. And it's tied to one specific ORM.

I'm not saying lucia is a name that we should keep, but I'm a little wary of people's expectations around auth. I can imagine Laravel developers saying 'aww, that's cute'.

manuel3108 commented 3 weeks ago

Maybe basic-auth or something

benmccann commented 3 weeks ago

I think we can add those things over time. We need to start somewhere

basic-auth feels weird to me because then as we add features, at what point do we remove basic- from the name?

Conduitry commented 3 weeks ago

'Basic auth' very much has an existing precise meaning already, which I really don't think we should try to go against.

AdrianGonz97 commented 3 weeks ago

How about lucia-guide or lucia-v4? We could also add lucia as an alias so that people can still write npx sv add lucia

benmccann commented 3 weeks ago

yeah, someone had suggested lucia-guide on discord - though someone else then responded that it sounds like you're setting up documentation or something along those lines

I kind of want to send a PR for a feature that's not in the Lucia guide just so we can stop calling it anything related to Lucia :laughing:

AdrianGonz97 commented 3 weeks ago

lucia-inspired then?

gives us leeway to change things in the future while also referencing where it loosely came from

benmccann commented 3 weeks ago

sounds fine to me

Rich-Harris commented 3 weeks ago

email-password-auth? It's not like Lucia is doing anything particularly unusual

Rich-Harris commented 3 weeks ago

(or maybe not that exact thing but you get the idea — something that says what it does)

AdrianGonz97 commented 3 weeks ago

i think at that point we may as well just call it auth so that it can prompt a multiselect for the different auth methods like: email-password, oauth, passkey, etc

┌  Welcome to the Svelte CLI! (v0.5.11)
│
◇  What would you like to add to your project?
│  auth
│
◆  Which auth methods would you like to include?
│  ◻ email-password
│  ◻ oauth
│  ◻ passkey
│  ...
└

And it's tied to one specific ORM.

i think we can make an attempt at making it a bit more generic

AdrianGonz97 commented 3 weeks ago

also, yes, it would look a bit silly for the time being since there would only be a single auth method available:

┌  Welcome to the Svelte CLI! (v0.5.11)
│
◇  What would you like to add to your project?
│  auth
│
◆  Which auth methods would you like to include?
│  ◻ email-password
└
MonsalvoGeoffrey commented 1 week ago

image Since each adder has text that is normally used to link to the library's documentation, I feel like this text is a better place to solve this problem that the title

Having it titled auth and the text beside it reading Following lucia's guideline (https://lucia-auth.com) would make it perfectly clear Sure, every other add-on only have a link, but I don't think it HAVE to be consitent, if lucia's an edge case, then it get the treatment of an edge case