fix: update lucia adder

sveltejs / cli

The Svelte CLI

MIT License

261 stars 11 forks source link

fix: update lucia adder #254

Closed pilcrowonpaper closed 3 weeks ago

pilcrowonpaper commented 3 weeks ago

Adds setSessionTokenCookie() and deleteSessionTokenCookie() (closes #122)
Fixes sessions to be consistent with lucia-auth.com. This isn't a security issue, but the hashing part wasn't implement properly which negated the benefits it provided.
Update generateUserId() to be consistent with generateSessionToken() and easier to deal with.
Removed return types to be consistent with the rest of the codebase.

I haven't added change sets yet and I'm not sure how to test the adder.

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 7e39333083421f1b20c983e125b11741dbf63503

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 3 weeks ago

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@254

commit: 7ff677f

manuel3108 commented 3 weeks ago

Cool, thanks!

You can test the adder by running pnpm sv add lucia insider the pnpm workspace. Or use pnpx https://pkg.pr.new/sveltejs/cli/sv@254 add lucia which was published instants ago

pilcrowonpaper commented 3 weeks ago

The generated TypeScript code works. I can't seem to get sv to generate JSDoc code tho. Is this expected?

AdrianGonz97 commented 3 weeks ago

That's expected. The JSDoc in this instance is only included when typescript isn't present in the project (or when using JSDoc just for type-checking).

pilcrowonpaper commented 3 weeks ago

Tested out with the published package and all the types seems to be working in both the TS and JSDoc version

benmccann commented 3 weeks ago

thank you!! this is a big help

we're hoping to add more things like oauth in the future. we're working on cleaning up some of our APIs to hopefully make it easier to add and maintain add-ons.

really appreciate you taking a look!