search

sveltejs / cli

The Svelte CLI
MIT License
258 stars 11 forks source link

chore: update `storybook` to v8.4.0 #298

Closed manuel3108 closed 1 week ago

manuel3108 commented 1 week ago

Relates #296

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 51c65c3330bc9a199d1ccdb22dfd3b653ec6cc34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---- | ----- | | sv | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new[bot] commented 1 week ago

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@298
pnpm add https://pkg.pr.new/sveltejs/cli/svelte-migrate@298

commit: 51c65c3

AdrianGonz97 commented 1 week ago

storybook has already been set to @latest as part of #181, so this PR isn't necessary unless we're wanting to pin it to a specific version again

JReinhold commented 1 week ago

If CI has been working with latest, maybe it was a temporary issue?

AdrianGonz97 commented 1 week ago

296 was strictly a local issue and was unrelated to CI. In fact, I don't think we ever saw a CI failure as a result of using @latest.

However, #293 is a CI related issue with storybook where we noticed that we can't run our storybook tests concurrently on windows (see https://github.com/sveltejs/cli/issues/293#issuecomment-2471848884) in CI (though, it works fine locally).

manuel3108 commented 1 week ago

storybook has already been set to @latest as part of #181, so this PR isn't necessary unless we're wanting to pin it to a specific version again

Uhh, somehow didn't notice that!