search

sveltejs / eslint-config

An ESLint config for Svelte
14 stars 11 forks source link

turn off "import/no-unresolved" #15

Closed tanhauhau closed 3 years ago

tanhauhau commented 3 years ago

unnecessary, unresolved modules, most likely caught by typescript check

and this will cause us to "adding legacy cruft to modules"

benmccann commented 3 years ago

Need to remove eslint-plugin-import from package.json as well I believe

Unfortunately Rollup will not catch these errors, so they could still happen in SvelteKit since it doesn't use TypeScript. I think it will create a warning in Rollup, but we already have a handful of warnings, so really easy to miss. But we may be able to turn it on independently there, so this is probably fine to merge here

tanhauhau commented 3 years ago

just to confirm, removing eslint-plugin-import will remove all the other rules comes with eslint-plugin-import, not just import/unresolved. (it comes with some stylistic lint rules) https://github.com/benmosher/eslint-plugin-import#style-guide

so we don't need linting rules from eslint-plugin-import right?

benmccann commented 3 years ago

Ah, ok. I didn't realize that. Let's leave it then

dummdidumm commented 3 years ago

Unfortunately Rollup will not catch these errors, so they could still happen in SvelteKit since it doesn't use TypeScript. I think it will create a warning in Rollup, but we already have a handful of warnings, so really easy to miss. But we may be able to turn it on independently there, so this is probably fine to merge here

I don't think so, part of the CI checks is running a type check with TSC on the files, and those check JS, too, so they should catch that.