search

sveltejs / eslint-config

An ESLint config for Svelte
14 stars 11 forks source link

Remove indentation rules #2

Closed benmccann closed 4 years ago

benmccann commented 4 years ago

https://github.com/typescript-eslint/typescript-eslint/issues/1824 says "The rule is in a broken state", which matches my experience. It tries to do some weird things with indentation. We could enforce indentation with prettier, which works much better. However, it will affect many more files and be much harder to deal with rebasing open PRs, so we'd want to clear out the review queues first

Conduitry commented 4 years ago

Unless I'm missing something, it looks like this also removed ESLint linting of .svelte files, which I don't think we want to do. Only the rules subsection should have been removed.

benmccann commented 4 years ago

Hmm. We still have plugins: ['svelte3'], so I assumed that .svelte files would still be linted since it was only the overrides that was removed. But according https://eslint.org/docs/user-guide/configuring it sounds like you're right. That's a pretty confusing naming... I'll test it out and send a PR to add that back