search

sveltejs / eslint-config

An ESLint config for Svelte
14 stars 11 forks source link

Deprecation of stylistic rules #32

Closed jrmajor closed 4 months ago

jrmajor commented 4 months ago

We use quotes and quote-props rules, which were deprecated in ESLint v8.53, among other stylistic rules.

All of these rules will be deprecated as of the next release, but will not be removed until at least ESLint v10.0.0 (if not later). You can continue to use them although you may see deprecation warnings in the ESLint CLI.

Do we want to ignore this for now, drop this rules from our config, or require them via @stylistic/eslint-plugin?

The third option would probably require a major version bump, since it adds a new peer dependency, so it may worth be doing before releasing #31, which also contains breaking changes.

benmccann commented 4 months ago

Let's get them from the plugin. It's fine to add a peer dep

jrmajor commented 4 months ago

OK, I'll follow up with a PR after #31 is merged.