feat(block-lang): Added support for multiple modules of the same type

sveltejs / eslint-plugin-svelte

ESLint plugin for Svelte using AST

https://sveltejs.github.io/eslint-plugin-svelte/

MIT License

294 stars 35 forks source link

feat(block-lang): Added support for multiple modules of the same type #511

Closed marekdedic closed 1 year ago

marekdedic commented 1 year ago

Closes #507

[ ] The enforcePresent option doesn't fail when there's only a context="module" block present (it checks for the presence of any block) - should it?

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 333bf9d3b89fa79adae32db9cb89b93078b34b6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------------- | ----- | | eslint-plugin-svelte | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

marekdedic commented 1 year ago

Thanks! What do you think about the enforcePresent thing?

ota-meshi commented 1 year ago

I've checked the behavior of that rule, and I don't think there's anything wrong with the current behavior. Did you have any concerns?

marekdedic commented 1 year ago

Well, this will not trigger with {script: "ts", enforceScriptPresent: true}:

<script context="module" lang="ts"></script>

<div>Hello!</div>

ota-meshi commented 1 year ago

I think that svelte file is fine. But if the language server can't handle that svelte file well, the rule might better report it, but I don't use it much with Svelte and TypeScript, so I'm not familiar with it 😅