search

sveltejs / eslint-plugin-svelte

ESLint plugin for Svelte using AST
https://sveltejs.github.io/eslint-plugin-svelte/
MIT License
282 stars 30 forks source link

docs: update README to use Svelte style guide #567

Closed benmccann closed 11 months ago

benmccann commented 11 months ago

Projects in the Svelte org use single quotes for JavaScript strings and our new project creation wizards like npm init svelte use single quotes for JavaScript strings as well. Using single quotes in the README would make it a lot easier to setup this plugin because I could copy/paste the code from the README into a project without having to update the formatting.

changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: e945a2fb994bc5a3404605e07cb79d332e72ab2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ota-meshi commented 11 months ago

Thank you for this PR! However, I think we need to change the prettier config and change the overall source code format of the repository. Is it possible for you to do that? If it is difficult, I will do it when I have time 😉

benmccann commented 11 months ago

yes, good idea! I didn't realize the readme was being formatted. done here: https://github.com/sveltejs/eslint-plugin-svelte/pull/568