search

sveltejs / eslint-plugin-svelte

ESLint plugin for Svelte using AST
https://sveltejs.github.io/eslint-plugin-svelte/
MIT License
297 stars 35 forks source link

feat: use synckit to support postcss-load-config v5 #665

Open JounQin opened 8 months ago

JounQin commented 8 months ago

close #636

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: fef79627e925c3f8d98941114bbb41dc36c3f2e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

JounQin commented 8 months ago 
  76:5  error  "postcss-load-config@^5.0.2" is not compatible with "node@^14.17.0||>=16.0.0". Allowed is: "node@>=18.0.0"  node-dependencies/compat-engines
  81:5  error  "synckit@^0.9.0" is not compatible with "node@^14.17.0||>=16.0.0". Allowed is: "node@^14.18.0||>=16.0.0"    node-dependencies/compat-engines

Do we want to release a major version for this?

JounQin commented 8 months ago

https://github.com/sveltejs/svelte/blob/ab13356008a609158da7493da4758d8d11645ac4/packages/svelte/package.json#L9

I believe we should match svelte itself.

ota-meshi commented 8 months ago

Thank you for the PR. I would like to release eslint-plugin-svelte v2.36 after the stable version of svelte v5 is released, and then work on the next major version.

baseballyama commented 8 months ago

Even if Svelte 5 is released, I don't think we can drop Node < 18 as long as we continue to support Svelte 4 and Svelte 3. I think it is a good idea to support only Svelte 5 in the next major version.

JounQin commented 8 months ago

I meant this PR should target on the next major version.

The main itself is targeting Svelte v5, how can I create a PR for old releases?

cc @ota-meshi

ota-meshi commented 8 months ago

There is currently no way to manage multiple versions in this repository 😓

JounQin commented 8 months ago

It needs multiple branches. For example https://github.com/mdx-js/eslint-mdx/tree/release-v2.