search

sveltejs / eslint-plugin-svelte

ESLint plugin for Svelte using AST
https://sveltejs.github.io/eslint-plugin-svelte/
MIT License
296 stars 35 forks source link

chore: fix tests to follow latest Svelte 5 #751

Closed baseballyama closed 4 months ago

baseballyama commented 4 months ago

I just added Node 22 but CI does not pass in https://github.com/sveltejs/eslint-plugin-svelte/pull/750

https://github.com/sveltejs/svelte/pull/11327 changes warning messages, so I mainly copied exist tests and optimized for Svelte 5.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 5027c8d0863e67732d68fc08d63cc9826e8332fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

baseballyama commented 4 months ago

So, I think https://github.com/sveltejs/svelte/pull/11327 changes messages, so messages between Svelte 4 and Svelte 5 is not same anymore. We need to add a feature that should be possible to declare a test specifically for Svelte 4 or Svelte 5.

baseballyama commented 4 months ago

We need to wait to solve this issue.

https://github.com/sveltejs/svelte/issues/11482