chore: migrate to monorepo

sveltejs / eslint-plugin-svelte

ESLint plugin for Svelte using AST

https://sveltejs.github.io/eslint-plugin-svelte/

MIT License

276 stars 29 forks source link

chore: migrate to monorepo #759

Closed baseballyama closed 3 weeks ago

baseballyama commented 1 month ago

WIP. Still there are a lot of todos. -> I will continue work on next weekend. (18th, 19th May)

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 4425571ff4385274e1156eaa62906ad4324231ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

baseballyama commented 1 month ago

@ota-meshi

I realized that currently we can not support ESLint v9.3.0 in docs project. (Not eslint-plugin-svelte itself.)

We need to fix vite-plugin-eslint4b, so I created a PR.

https://github.com/ota-meshi/vite-plugin-eslint4b/pull/51 https://github.com/ota-meshi/vite-plugin-eslint4b/pull/53

baseballyama commented 1 month ago

@ota-meshi Almost done but https://github.com/ota-meshi/vite-plugin-eslint4b/pull/51 and https://github.com/ota-meshi/vite-plugin-eslint4b/pull/53 are blocker. I will do self-review for this but I don't have confident that changeset release works properly or not😅

baseballyama commented 3 weeks ago

@ota-meshi

I need your help! Still I can not build docs project due to file path mismatch.

https://github.com/sveltejs/eslint-plugin-svelte/assets/19153718/becd51d0-1a56-49d3-be79-7a54d6d72dd9

I think https://github.com/ota-meshi/vite-plugin-eslint4b/pull/55 breaks this. But I'm not sure how to solve the issue. Maybe we can revert I think https://github.com/ota-meshi/vite-plugin-eslint4b/pull/55 or you have better idea.

ota-meshi commented 3 weeks ago

I think https://github.com/ota-meshi/vite-plugin-eslint4b/pull/55 breaks this.

Hmm... It was a CI error so I made some changes. I will check out this branch later and give it a try.

ota-meshi commented 3 weeks ago

I fixed vite-plugin-eslint4b and I think the build script is passing. However, the playground launched by the dev script still doesn't work. I don't know what the difference is yet...

baseballyama commented 3 weeks ago

@ota-meshi

Thank you for fixing this! As far as I know, the dev command is not working properly on the main branch either. So I think we can merge this PR after completing the following tasks:

Ensuring that the release process is not broken (since CI cannot check this, we need to verify it manually)
Conducting a general code review

baseballyama commented 3 weeks ago

This is not related to this PR, but do you think it is possible to convert the documentation project to ESM? There are plans to consolidate Svelte-related documentation into a single omnisite, which will need to be migrated to ESM before this can be done.

ota-meshi commented 3 weeks ago

This is not related to this PR, but do you think it is possible to convert the documentation project to ESM?

Yes, I believe we can migrate our documentation to the ESM project.

baseballyama commented 3 weeks ago

Hum...

baseballyama commented 3 weeks ago

I'm fixing.

baseballyama commented 3 weeks ago

Fixed: https://github.com/sveltejs/eslint-plugin-svelte/actions/runs/9427331361/job/25971325775

baseballyama commented 3 weeks ago

And I confirmed that the site is working properly.