Open danieldiekmeier opened 1 year ago
Hi, Sentry dev 👋
I asked about this a while ago here along with some other source maps related stuff: https://github.com/sveltejs/kit/discussions/9608
We would really appreciate it if this was fixed. Ideally, the source maps from the Node adapter would directly map to the actual sources and not the built files in .svelte-kit
. Then we wouldn't have to flatten them at all :)
Thanks!
Adding a +1 on this! It's crazy difficult to track client-side errors without it, and we're building into a custom express server that runs a ton of legacy code, so we can't afford to use anything other than adapter-node
.
Since this got rolled back, has anyone seen anything about when they'll reattempt the adapter-node sourcemap fix? Clientside sentry is unusable until that gets resolved :(
A fix could be to update the source maps while copying them. (But maybe there are better options.)
I'm wondering if a simple option might be just changing the output path in the node adapter to match the original directory hierarchy?
I think this was fixed in #10041
I think this was fixed in #10041
It got reverted in 1.3.1 https://github.com/sveltejs/kit/pull/10314 so it is still an issue.
We would really appreciate it if this issue was bumped in priority. The current behaviour is blocking some of our users because our source maps flattening approach with sorcery
fails sometimes due to faulty source maps in the chain (example: https://github.com/getsentry/sentry-javascript/issues/10589).
My request would be that adapter-node
either completely removes the build step or, if not possible otherwise, the source maps emitted by adapter-node just link back to the actual source files. Right now, they link to the intermediate source files in .svelte-kit
which is why we need to flatten them. (more context in https://github.com/sveltejs/kit/discussions/9608)
Obviously, it's not ideal that the path to the source files isn't correct at the moment but at least this doesn't fully block our users.
Describe the bug
When you turn on sourcemaps in Vite, SvelteKit will generate sourcemaps even for the server. This is great! But during the build,
@sveltejs/adapter-node
moves the generated files, for example from.svelte-kit/output/server/foo.js
to.svelte-kit/adapter-node/foo.js
, breaking the relative paths to the sources in the sourcemaps.This is the code that moves the files: https://github.com/sveltejs/kit/blob/51f3e668ca5c433de0215cdfd627fc06fd030d47/packages/kit/src/core/adapt/builder.js#L207-L209
I noticed this because I wanted to setup Sentry's new SvelteKit integration, but the sourcemaps would just not work. Sentry is actually using sorcery to try to flatten all the sourcemaps from the different steps of the build: https://github.com/getsentry/sentry-javascript/blob/41fef4b10f3a644179b77985f00f8696c908539f/packages/sveltekit/src/vite/sourceMaps.ts#L136-L139
This almost works, except that
adapter-node
moves the files, thus breaking the chain.A fix could be to update the source maps while copying them. (But maybe there are better options.)
Reproduction
Repo: https://github.com/danieldiekmeier/reproduction-adapter-node-sourcemaps
Logs
No response
System Info
Severity
annoyance
Additional Information
No response