Nesting more than one slot component in a layout component makes $page lose reactivity

paoloricciuti commented 1 year ago

Describe the bug

It all started with a discord user asking a simple question https://discord.com/channels/457912077277855764/1119224594910412862/1119224594910412862

This user had a problem with stores so we helped him to create a derived store. But than we went back again with another problem...it didn't seemed to work as intended (https://discord.com/channels/457912077277855764/1119224594910412862/1119289050013118625)

Poking around that example i wasn't able to understand why it didn't worked and i kinda got nerdsniped. My first toguht was that it was a problem with konsta but it didn't seemed like they were doing anything fancy. Modifing the konsta components to make them as barebone as possible inside the node modules i went ahead and deleted everything leaving just the slots...the problem still occured.

So apparently if you have a situation like this where the slot for the layout is nested inside a component that has a slot inside another component with a slot $page stop being considered dirty (i also checked that this is the case with a step by step debugger in chrome).

Reproduction

Go to https://www.sveltelab.dev/hndxsmadcbwegdj
Navigate to /auth/login
Observe that the $path.url.pathname outside is in sync with the one inside
Click the link to Forgot
Observe that the $path.url.pathname outside is out of sync with the one inside

Logs

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
  npmPackages:
    @sveltejs/adapter-auto: ^2.0.0 => 2.1.0 
    @sveltejs/kit: ^1.5.0 => 1.20.4 
    svelte: ^3.54.0 => 3.59.2 
    vite: ^4.0.0 => 4.3.9

Severity

serious, but I can work around it

Additional Information

I also checked for navigating to see if that was a problem of all sveltekit stores and it didn't seem like that was the case

ghostdevv commented 1 year ago

I believe this is a duplicate of #10116 - would be great to put your reproductions/findings in that issue :pray:

paoloricciuti commented 1 year ago

I believe this is a duplicate of #10116 - would be great to put your reproductions/findings in that issue 🙏

Ups...I tried to find similar issues but found nothing...I'll report back there even tho their findings are pretty similar to mine

sveltejs / kit