sveltejs / kit

web development, streamlined
https://kit.svelte.dev
MIT License
17.81k stars 1.78k forks source link

chore: fixed typo in all svelte configs of create-svelte #12146

Closed jonasgeiler closed 3 weeks ago

jonasgeiler commented 3 weeks ago

WebStorm notified me of a typo in the svelte.config.js file after creating a new project with create-svelte. I also cross-checked with languagetool.org and they both said that a comma was missing, so I added it :) A very dumb PR but I hope it's enough.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Edits

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: fe03e5f5a477006966ba7e263501d1d24d743a80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gterras commented 3 weeks ago

The typo is actually the added coma here?

jonasgeiler commented 3 weeks ago

The typo is actually the added coma here?

Uhhh not as far as I know. Webstorm and LanguageTool told me a comma was MISSING. I don't know which is the correct form, I was just bothered by the typo error notification from WebStorm. LanguageTool actually also wanted me to add a "have" after "you" too but not sure if that's needed here.

TheOnlyTails commented 3 weeks ago

This is the Oxford Comma, whose usage is controversial among editors. The general guideline is that both including and omitting it are not errors, but you should remain consistent with its usage (either always use it, or don't use it at all).

gterras commented 3 weeks ago

IMO it's interesting to disambiguate, here it's not really needed.