sveltejs / language-tools

The Svelte Language Server, and official extensions which use it
MIT License
1.25k stars 198 forks source link

`$$Props` and missing children prop #2218

Open dummdidumm opened 11 months ago

dummdidumm commented 11 months ago

Describe the bug

When using $$Props, children isn't likely set on it in Svelte libraries compiled with version 5. We need to add it in that case.

Reproduction

https://discord.com/channels/457912077277855764/1153350350158450758/1178260814239629353

Expected behaviour

No type error

System Info

Which package is the issue about?

svelte2tsx

Additional Information, eg. Screenshots

No response

amit13k commented 11 months ago

No such errors are displayed after downgrading svelte vscode extension to v108.0.0.

dummdidumm commented 11 months ago

Actually, the better fix is probably to adjust the typings in Svelte 5 to include children as a snippet prop on the attributes