Fix build issues - Githubissues

sveltejs / realworld

SvelteKit implementation of the RealWorld app

https://realworld.svelte.dev

MIT License

2.24k stars 353 forks source link

Fix build issues #114

Closed cmcculloh closed 2 years ago

cmcculloh commented 2 years ago

Changes %svelte. to %sveltekit. in src/app.html
Comments out an unused CSS selector throwing a warning on build

I'm actually slightly unsure about this one, having never used netlify. When I ran a build and saw 60 untracked files suddenly appear it seemed odd to me not to follow the convention for outDir (excluding from version control).

Adds /.netlify directory to .gitignore

cmcculloh commented 2 years ago

Well. I have zero experience with Netlify and no time to figure this out right now unfortunately.

All I know is I get this locally without these changes:

But with them, the github checks fail on Netlify:

😕

Feel free to close this PR if you'd like.

benmccann commented 2 years ago

Thanks. I just upgraded to the latest SvelteKit here: https://github.com/sveltejs/realworld/commit/2bce75a37ae43f1a587fb1b2c30c003efa00eeb6

I think the issue was that you didn't update the npm lock file.