Url plugin should match ambient.d.ts

sveltejs / sapper-template

Starter template for Sapper apps

703 stars 214 forks source link

Closed bjon closed 4 years ago

bjon commented 4 years ago

Fixed jpeg and webp imports from src/node_modules/images.

benmccann commented 4 years ago

I'm not sure why @rollup/plugin-url doesn't include these by default, but that seems like a better place for this change

If we were going to override the default I would think we should just include the whole images directory rather than specifying file types

bjon commented 4 years ago

@benmccann :+1:

bjon commented 4 years ago

@benmccann btw, did you mean I should do a PR in plugin-url instead?

benmccann commented 4 years ago

If you'd like. I don't think we'll accept this PR as is

bjon commented 4 years ago

I opened a PR in URL plugin instead

benmccann commented 4 years ago

Ok. I'll go ahead and close this one since it looks like the PR to the URL plugin has been approved

bjon commented 4 years ago

:+1: