Closed konnextv closed 4 years ago
It doesn't sound to me like there's any issue in Sapper: https://github.com/lukeed/sirv/issues/82#issuecomment-691699841
I don't think we'd change the template since the template uses Polka
I understand. However, other people will run into this in the feature because in the template it just says polka() // You can also use Express
.
In my opinion there should be a notice about this somewhere but if you think differently that is also fine.
Describe the bug Sirv does not serve files with spaces when using express, instead you get a 404. This issue exists with sirv@1.0.0 or later.
To Reproduce
./static/foo bar.txt
/foo%20bar.txt
in the browserExpected behavior I know that filenames containing spaces and other special characters are not best practice. However, you run into them anywhere and I would not expect sapper to just show a 404 without any further info.
Severity I know about it and fixed it myself. However, that took me some time and either
Additional context
Issue at sirv: URLs not correctly parsed for ^1.0.0 with express
My workaround: (maybe this could be integrated in the template with a switch "express used")