sveltejs / sapper

The next small thing in web development, powered by Svelte
https://sapper.svelte.dev
MIT License
6.99k stars 432 forks source link

Fixed Dynamic Parameters in routes containing spaces #1782

Closed aldrino closed 1 year ago

aldrino commented 3 years ago

The change here is to appropriately fetch the baseUrl in cases where the URL is encoded.

Current req.baseUrl - http://localhost:3000/b/ (Fails loading of assets) Expected req.baseUrl - http://localhost:3000/

aldrino commented 3 years ago

Issue related to - https://github.com/sveltejs/sapper/issues/1781

surepy commented 3 years ago

I was literally about to make the same pr lol rip my time

also related to #1002 and #1174 (Unicode characters get encoded.)

benmccann commented 3 years ago

This would need a test. I'm a bit hesitant to merge anything else into Sapper though. Is there any reason you don't just use SvelteKit?

benmccann commented 1 year ago

SvelteKit 1.0 is now out and Sapper is deprecated, so I'm going to close this