pin site versions - Githubissues

sveltejs / sites

Monorepo for the sites in the Svelte ecosystem

https://svelte.dev

MIT License

286 stars 123 forks source link

pin site versions #438

Closed dummdidumm closed 1 year ago

dummdidumm commented 1 year ago

pin repl version so we can freely adjust it in the meantime (it has incompatible style changes)
make hn/svelte.dev packages private so we can't accidentally publish them

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
hn	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 10, 2023 at 4:05PM (UTC)
svelte-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 10, 2023 at 4:05PM (UTC)

dummdidumm commented 1 year ago

I don't understand the mysterious pnpm lock failure

dummdidumm commented 1 year ago

This is getting weirder by the minute. I removed all node_modules and the lockfile locally to start a fresh pnpm i and the error persists

dummdidumm commented 1 year ago

From tests in #439 it seems that adding back publishDirectory: package to the lockfile fixes the issue. No idea why

Tal500 commented 1 year ago

@Rich-Harris @benmccann Because of this sad thing I didn't see the fix of the REPL in #445... It blocks too many things, can you upgrade the REPL or you must fix some styling issues?

dummdidumm commented 1 year ago

ah yeah that's a bummer. We can't update those packages right now because they work with the new style guide now - we plan to release an overhaul of the Svelte site soon, it should be in there then.

Tal500 commented 1 year ago

ah yeah that's a bummer. We can't update those packages right now because they work with the new style guide now - we plan to release an overhaul of the Svelte site soon, it should be in there then.

Any update?

benmccann commented 1 year ago

We'll release the new site in the next week or two