Svelte docs: ts-toggle button doesn't work

Jamoverjelly commented 9 months ago

Describe the bug

The button inside the ts-toggle div appearing at the base of the documentation's table of contents (last child of toc-container) doesn't switch the code examples from TypeScript to JavaScript

Reproduction

n/a

Logs

No response

System Info

n/a

Severity

annoyance

geoffrich commented 9 months ago

I can't reproduce this - what page are you seeing this on?

e.g. the on:eventname docs correctly toggle between JSDoc and TS (https://svelte.dev/docs/element-directives#on-eventname)

JS:

TS:

Jamoverjelly commented 9 months ago

Thanks for your attention to my inquiry, Geoff.

I began reading through the docs on svelt's store implementation here https://svelte.dev/docs/svelte-store

I didn't realize this before, but it looks as though other snippets on the page that have their filename included change their extension to express the difference between a JS and TS file, though all the function signatures appear to be written in TypeScript. Maybe that's intentional, but I was expecting the signatures to be expressed in plain JavaScript by default.

Jamie

On Mon, Oct 2, 2023 at 12:08 PM Geoff Rich @.***> wrote:

I can't reproduce this - what page are you seeing this on?

e.g. the on:eventname docs correctly toggle between JSDoc and TS ( https://svelte.dev/docs/element-directives#on-eventname)

JS: [image: image] https://user-images.githubusercontent.com/4992896/272024446-c616d9cd-961e-43f5-9ad7-c163e42aea17.png

TS: [image: image] https://user-images.githubusercontent.com/4992896/272024499-ba39a289-b1f9-4b53-ab6b-8a161b96243c.png

— Reply to this email directly, view it on GitHub https://github.com/sveltejs/sites/issues/541, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSB7DJIB6FSYEHNPTW5HCTX5LRINAVCNFSM6AAAAAA5NUQFZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGMYDGOBXGM . You are receiving this because you authored the thread.Message ID: @.***>

sveltejs / sites