search

sveltejs / svelte-devtools

A browser extension to inspect Svelte application by extending your browser devtools capabilities
https://chromewebstore.google.com/detail/svelte-devtools/kfidecgcdjjfpeckbblhmfkhmlgecoff
MIT License
1.49k stars 79 forks source link

Zip file missing icons? #7

Closed keithj2780 closed 5 years ago

keithj2780 commented 5 years ago

Installing from ZIP on chrome 75 (Linux) fails with - manifest is missing icons.

Workaround - deleting icons section from manifest - it installs successfully.

RedHatter commented 5 years ago

I am unable to reproduce. What zip file are you using? The 1.0.0 from the releases page?

eugeneh-wang commented 5 years ago

I don't know if this is the same issue, but just had some trouble installing this. Cloned from GitHub, ran npm install and npm run package.

You have a build:icon script that looks for svelte logo icons (png) in specific sizes. They weren't there, so then it tries to run Inkscape to make the icons. Apparently node-inkscape requires you have Inkscape installed, which I don't.

Started installing Inkscape but that was no fun, so I just removed the build:icon script. And also the icons section from manifest.json.

RedHatter commented 5 years ago

Yes, building the icons requires inkscape.

If I understand the original issue the icons were missing from the ZIP, not when building.

RedHatter commented 5 years ago

Closing for lack of activity.

keithj2780 commented 5 years ago

Yes, the original issue was the icons were missing from the ZIP. I just downloaded V1.1.1, the same issue remains - the are no icon files extracted. And the same workaround still works.

RedHatter commented 5 years ago

You must have downloaded the Source code (zip). That's an automatically generated bundle of master at the time of the release not a packaged zip. Version 1.0.0 has svelte_devtools-1.0.0.zip which is a packaged zip. Releases after that point no longer include packaged archives since svelte-devtools has been accepted in both the chrome and firefox addon stores.