search

sveltejs / svelte-devtools

A browser extension to inspect Svelte application by extending your browser devtools capabilities
https://chromewebstore.google.com/detail/svelte-devtools/kfidecgcdjjfpeckbblhmfkhmlgecoff
MIT License
1.44k stars 78 forks source link

Fix broken chrome version. #78

Closed iandoesallthethings closed 1 year ago

iandoesallthethings commented 2 years ago

Got this working in chrome and Arc thanks to @wheezard in #63

bershanskiy commented 2 years ago

@iandoesallthethings Hi, did you include package-lock.json on purpose or accidentally? Since the it was not part of the repo, it's possible that the original author did not include it intentionally.

iandoesallthethings commented 2 years ago

Ah, that was unintentional. Fixed it.

bershanskiy commented 1 year ago

@iandoesallthethings I just tested on Firefox and this PR breaks extension on Firefox since Firefox resolves paths relative to the extension page. A proper fix would be to wrap that line in #if/#else/#endif and process the whole file with rollup-plugin-jscc like other files in the project.

bershanskiy commented 1 year ago

Also, #70 fixes the same bug but a bit differently.

bershanskiy commented 1 year ago

Relevant Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1364293

bershanskiy commented 1 year ago

The Chromium DevTools bug (linked above) was fixed and fix was already rolled into Chromium. I tested on Chromium Version 108.0.5358.0 (Developer Build) (64-bit) and sender.url was fine. Most likely, Chromium Canary was already fixed too. We can expect Chromium 108 to release with Svelte DevTools working again.