Refactor code, drop more legacy stuff

sveltejs / svelte-loader

Webpack loader for svelte components.

MIT License

597 stars 72 forks source link

Refactor code, drop more legacy stuff #158

Closed non25 closed 3 years ago

non25 commented 3 years ago

Here's a branch for refactoring. I'll put some changes that I find reasonable here. Get involved and tell me what you would want to see here. Fixes #95, Closes #142, Closes #93, Closes #77

non25 commented 3 years ago

@benmccann do you have any idea why changes to the index.js broke should preprocess test? Can't seem to find a way to fix it.

Wow.. that was dumb. :grin: One min.

benmccann commented 3 years ago

This PR's a bit difficult to review since https://github.com/sveltejs/svelte-loader/pull/159 was integrated. I just merged that one so if you rebase against master hopefully the diff for it won't appear here anymore

non25 commented 3 years ago

This PR's a bit difficult to review since #159 was integrated. I just merged that one so if you rebase against master hopefully the diff for it won't appear here anymore

I've got two conflicts rebasing! OMG! Done.

non25 commented 3 years ago

Also I don't know about this line:

Add Node 14 support and fix intermittent crashes when using cache-loader in front of svelte-loader (#125)

There's no virtual stuff in repo anymore. Working cache was achieved by dropping virtual modules altogether. Also #131 was fixed.