sveltejs / svelte-preprocess

A ✨ magical ✨ Svelte preprocessor with sensible defaults and support for: PostCSS, SCSS, Less, Stylus, Coffeescript, TypeScript, Pug and much more.
MIT License
1.73k stars 147 forks source link

v5 #562

Closed kaisermann closed 1 year ago

kaisermann commented 1 year ago

Closes #504, #559, #485, #452, #508. This PR basically does what is described in #504:

From #504 (cc @dummdidumm)

Only support the new SASS API (right now we only support the legacy API). This means bumping the peer dep.

This will be the only thing not implemented right now as I'm not managing to make it work in the test environment. There's also a problem with sync/async importers which I'm not sure how to deal with just yet.

kaisermann commented 1 year ago

Updating to sass only and replacing the render call with compileString is harder than I thought 😅

kaisermann commented 1 year ago

@dummdidumm The result of the typescript transformer still returns a diagnostics list alongside the rest of the Processed result. Is this used somewhere within the language server or in any other tool? Otherwise, I think we could remove this

kaisermann commented 1 year ago

@benmccann Just released v5 🎉 those installation errors should stop now 🙏

dummdidumm commented 1 year ago

@dummdidumm The result of the typescript transformer still returns a diagnostics list alongside the rest of the Processed result. Is this used somewhere within the language server or in any other tool? Otherwise, I think we could remove this

Nope, not used, so can be removed. Thank you for releasing the next major 🎉

benmccann commented 1 year ago

thanks!!