sveltejs / svelte

web development for the rest of us
https://svelte.dev
MIT License
80.24k stars 4.27k forks source link

Svelte 5: Creating snippets in `.svelte.js` / `.svelte.ts` files #11261

Open rChaoz opened 7 months ago

rChaoz commented 7 months ago

Describe the problem

I would say that, undoubtedly, the biggest (and only?) advantage React has over Svelte, is jsx. Just open any js/ts file and write:

const myFunc = (arg) => (<p>{arg}</p>)

No need to create a component. This is incredibly helpful, for example, when using libraries like Storybook, with decorator functions. A decorator function in Storybook in React might look like this:

(Story, ctx) => <div style={{ margin: ctx.globals.marginSize + "rem" }}><Story/></div>

To implement this feature in Svelte, decorator functions return a component in Svelte Storybook. To do the same, one would have to write this as the decorator:

import MarginDecorator from './MarginDecorator.svelte'
import { setContext } from 'svelte'

(_, ctx) => {
    setContext("marginDecoratorSize", ctx.globals.marginSize + "rem")
    return MarginDecorator
}

and

// MarginDecorator.svelte

<script>
    import { getContext } from 'svelte'
    const size = getContext("marginDecoratorSize")
</script>

<div style="margin: {size}"><slot/></div>

Generally, to bridge the gap between Svelte and regular JS/TS, one has to write a Svelte component file for everything. This is one of the less fun parts of Svelte - sometimes, you need to be able to write some Svelte code, and writing a new component file, giving it a name, figuring out where to place it just sucks. This is also a lot of work for library authors - for example, to this day, Storybook still doesn't support creating stories of components with slots. Additionally, just to make the feature above work, they inject the decorator code into an actual Svelte component, which allowed calling setContext from withing the decorator function.

Describe the proposed solution

Since snippets, under the hood, are just plain JS values/functions, it would be awesome to be able to write snippets directly in .svelte.ts / .svelte.js files. Then, one could write a decorator like this:

(Story, ctx) => {
    const decorator = $snippet`
        <div style="margin: ${ctx.globals.marginSize}rem">
            {@render Story()}
        </div>
    `
    return decorator
}

Snippets with arguments could look like so:

const s = $snippet.args((a, b) => $snippet`
    <div>${a}</div>
`)
// even like this:
$snippet((a, b) => `
    <div>${a}</div>
`)
// if tag function is not needed for implementation

The possibilities would be endless!

Alternative syntax

const decorator = $snippet`
// Maybe skip name - {#snippet()}
{#snippet s()}
...
{/snippet}    
`

Regardless, I think the requirements for any syntax are:

Questions

How should ${...} be treated/used? There are a couple of possibilities here:

Importance

would make my life easier

7nik commented 7 months ago

This will mean that neither JS/TS parsers nor JSX parsers will be able to understand .svelte.js/ts files, which is not acceptable. In addition, in VSCode, you cannot preprocess .js/ts files, which will break even more things. Plus, you cannot @render a component and mount() a snippet.

Maybe #10350 and #10678 could simplify your life.

rChaoz commented 7 months ago

@7nik My bad! True, .svelte.ts is still just a .ts file. Updated the post accordingly, to use a rune instead with regular JS syntax.

ssssota commented 6 months ago

Hi! I made svelte-jsx-snippet to create snippets with JSX.

ssssota commented 4 months ago

Now, we can create snippet everywhere! https://github.com/sveltejs/svelte/pull/12425 https://github.com/sveltejs/svelte/releases/tag/svelte%405.0.0-next.189