fix: prevent ownership validation from infering with component context

dummdidumm commented 2 weeks ago

Ownership validation had a false positive when rendering a component as slotted content of another component. To fix this, #11401 did set the current component context to the context the snippet was declared in, not to the context it is rendered in. This was flawed because it means that component context was altered in a way that setContext/getContext failed because the parent chain was incorrect. This fixes that by introducing a separate global (dev time only) which tracks the component function the ownership needs.

fixes #11429

Before submitting the PR, please make sure you do the following

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] Prefix your PR title with feat:, fix:, chore:, or docs:.
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests and linting

[x] Run the tests with pnpm test and lint the project with pnpm lint

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: d87c13956704c49c7af3d9d961f58b6022f4d197

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------ | ----- | | svelte | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dummdidumm commented 2 weeks ago

Self-merging because this is a pretty nasty bug

sveltejs / svelte