Open webJose opened 2 days ago
Sounds like you're half way there towards making a PR :P
I would but I don't know JsDoc enough. I quickly gave it a shot. I defined the type in packages/svelte/types/index.d.ts
, but the type needs importing in packages/svelte/src/internal/client/render.js
. This is where I don't know: I see zero imports from the file I modified, and to my surprise there's an index.d.ts
file in src
. So I'm at a loss here. If you can guide me through this, I'll complete the PR.
Can you create a draft PR with what you already have?
Import option examples:
// These give you the `Snippet` to use elsewhere:
/** @import { Snippet } from 'svelte'; */
/** @typedef {import('svelte').Snippet} Snippet */
/**
* Or inline import:
* @param {import('svelte').Snippet} arg
*/
function fun(arg) { /* ... */ }
Here's the PR: https://github.com/sveltejs/svelte/pull/13674
Describe the problem
For declaring ambient modules and even regular types for code that uses
mount()
and would like to type things, the type for theoptions
parameter is not named, and instead is defined inline:Describe the proposed solution
Declare the options parameter's type as its own type:
BTW, now that I see the type, maybe the following is more succinct?
Importance
nice to have