sveltejs / svelte

web development for the rest of us
https://svelte.dev
MIT License
79.68k stars 4.23k forks source link

`sv check` should not warn about non-reactive code when runes are disabled #14034

Open ptrxyz opened 2 days ago

ptrxyz commented 2 days ago

Describe the bug

I am using sv check with a code base that uses Svelte 5, but non-runes mode. I disabled runes in my svelte.config.js using the compilerOptions: { runes : false } setting. However I still get the warnings "Warn: Properties of objects and arrays are not reactive unless in runes mode...."

Reproduction

Logs

tmp/: sv check
/tmp/src/routes/(uishell)/(helpers)/tasks/+page.svelte:33:80
Warn: Properties of objects and arrays are not reactive unless in runes mode. Changes to this property will not cause the reactive statement to update (svelte)

    $: AC = new APIClient(Schematics, data.selectedUnit ? data.selectedUnit.key : ALL_UNIT.key)
    $: RS = new RecordStore(

### System Info

```shell
System:
    OS: Linux 6.11 Arch Linux (btw)
    CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
    Memory: 55.72 GB / 62.71 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 23.1.0 - /usr/bin/node
    Yarn: 1.22.22 - /usr/bin/yarn
    npm: 10.9.0 - /usr/bin/npm
    pnpm: 9.12.2 - /usr/bin/pnpm
    bun: 1.1.30 - ~/bin/bun
  Browsers:
    Brave Browser: 130.1.71.118
    Chromium: 130.0.6723.69

Severity

annoyance

paoloricciuti commented 1 day ago

This is actually a warning for non runes mode because if you import something and access it and use it in a labeled statement that thing it's not reactive

repl

dummdidumm commented 1 day ago

I'm wondering how much use this warning is / how many false positives it yields.

paoloricciuti commented 1 day ago

I'm wondering how much use this warning is / how many false positives it yields.

tbf i don't think people are importing stuff expecting it to be reactive but overall i'm more inclined to mute a warning than have false negatives...i wonder if there's some github search we can do to check 🤔

benmccann commented 1 day ago

here's a Svelte 5 upgrade PR that has lots of ignores related to this warning if you want to see some examples: https://github.com/immich-app/immich/pull/13738