sveltejs / svelte

Cybernetically enhanced web apps
https://svelte.dev
MIT License
78.46k stars 4.11k forks source link

Certain examples aren’t working properly in v3 #2078

Closed chris-morgan closed 5 years ago

chris-morgan commented 5 years ago

I just tried all the 7guis examples, and two of them are broken. Samples other than the 7guis ones may or may not be broken. Doubtless a full review will be needed before v3.

Flight booker: startDate() and endDate() aren’t reactive, so the book button doesn’t behave itself.

CRUD: first and last inputs aren’t editable while a person is selected, because as soon as you change them, the last $ block kicks in and resets them.

chris-morgan commented 5 years ago

Demo links from the guide are all broken. e.g. https://v3.svelte.technology/repl?version=3.0.0-beta.3&demo=1igzsq8.

It looks like you're using Rollup in a non-Node.js environment. This means you must supply a plugin with custom resolveId and load functions

If you start the REPL by other means than ?demo=1igzsq8, and copy all the content in, it works.

Conduitry commented 5 years ago

The way examples are set up has changed since this issue was created, and I think a lot of things have been ironed out since then - but here's what I just found on another sweep through the examples:

Rich-Harris commented 5 years ago

Demo links from the guide are all broken

The docs no longer contain examples, as all the interactive stuff is in /tutorial. Examples have been updated. Thanks!

bionicles commented 5 years ago

Crud example doesn’t allow input value edit right now