search

sveltejs / template

Template for building basic applications with Svelte
1.74k stars 806 forks source link

`SIGTERM` has no effect #243

Open probablykasper opened 3 years ago

probablykasper commented 3 years ago

SIGTERM has no effect for npm run dev.

I'm using Svelte with Tauri (related issue: https://github.com/tauri-apps/tauri/issues/1626), and this is causing leftover processes running after Tauri exits.

Reproduction

  1. Get the PID of the current terminal instance: echo $$
  2. npm run dev
  3. In a new terminal instance, run pkill -TERM -P <PID>

Info

macOS 10.15.7 Node.js v14.16.0 npm 6.14.11

dRAT3 commented 3 years ago

Please fix this, it's annoying as hell, I have a bunch of node instances running for my language servers so I can't use killall, I have to use recursive shell functions just to terminate node

orhun commented 2 years ago

I'm having the same problem here. Any updates on this?

probablykasper commented 2 years ago

What @amrbashir said in https://github.com/tauri-apps/tauri/pull/2883 might help:

A bit of an update, in svelte official template, I found out that they are using ignore instead of inherit https://github.com/sveltejs/template/blob/4fd09c2a191b017ca9eb9cb9921fa873e95f44b4/rollup.config.js#L21

Switching it to inherit doesn't fix the whole issue but at least Ctrl+C terminates it properly.