search

sveltejs / vite-plugin-svelte

Svelte plugin for http://vitejs.dev/
MIT License
844 stars 103 forks source link

Lowers log level to debug #806

Closed Radiergummi closed 10 months ago

Radiergummi commented 10 months ago

This message isn't immediately actionable for developers and can reasonably be considered debugging output. Therefore, the log level has been updated to reflect this.

This fixes #803.

Radiergummi commented 10 months ago

@dominikg as requested; here goes. I was pretty confident you don't require tests for logging, so this PR is as bare-bones as it gets.

dominikg commented 10 months ago

the PR also needs a changeset, you can create it with pnpm changeset and following the prompts. (select vite-plugin-svelte, select patch, write a short note like "changed loglevel of output unchanged message to debug to reduce verbosity")

Radiergummi commented 10 months ago

the PR also needs a changeset, you can create it with pnpm changeset and following the prompts. (select vite-plugin-svelte, select patch, write a short note like "changed loglevel of output unchanged message to debug to reduce verbosity")

Changeset created, waiting for approval.

Augasty commented 10 months ago

Hi @Radiergummi and @dominikg, I was trying to solve the issue, found the bug and after solving it, I came to see that @Radiergummi has already raised a PR. I am not entirely sure whether I should raise my own PR (This is my first try at open source contribution, so please excuse me if I am doing something wrong).

So, I am uploading my changes anyway, thanks.

dominikg commented 10 months ago

Thank you @Radiergummi !

@Augasty raising a duplicate PR is usually not a good idea, but participating in issues and PRs is. Your PR itself looks fine too, but this one is going ahead as it was first.

Augasty commented 10 months ago

Absolutely okay with it. And thanks a lot for feedback.