search

sveltejs / vite-plugin-svelte

Svelte plugin for http://vitejs.dev/
MIT License
819 stars 99 forks source link

Escape keys #880

Closed ryangclark closed 2 months ago

ryangclark commented 3 months ago

Implements escapeKeys as an enhancement to allow closing the inspector via a hotkey, as requested by https://github.com/sveltejs/vite-plugin-svelte/issues/858.

By default, the escapeKeys are Backspace and Escape, though they can be configured via SVELTE_INSPECTOR_OPTIONS like the inspector's other hotkeys.

dominikg commented 2 months ago

thank you for working on this. Please run pnpm generate:types in the inspector directory and commit/push the changes. This is needed because we ship the source to npm directly without an additional build step.

ryangclark commented 2 months ago

Types generated.

Thanks for your review, and for all your previous work.